Commit df3ef3af authored Nov 12, 2013 by P J P Committed by Linus Torvalds Nov 13, 2013

init/do_mounts_rd.c: fix NULL pointer dereference while loading initramfs



Make menuconfig allows one to choose compression format of an initial
ramdisk image.  But this choice does not result in duly compressed initial
ramdisk image.  Because - $ make install - does not pass on the selected
compression choice to the dracut(8) tool, which creates the initramfs
file.  dracut(8) generates the image with the default compression, ie.
gzip(1).

If a user chose any other compression instead of gzip(1), it leads to a
crash due to NULL pointer dereference in crd_load(), caused by a NULL
function pointer returned by the 'decompress_method()' routine.  Because
the initramfs image is gzip(1) compressed, whereas the kernel knows only
to decompress the chosen format and not gzip(1).

This patch replaces the crash by an explicit panic() call with an
appropriate error message. This shall prevent the kernel from
eventually panicking in: init/do_mounts.c: mount_block_root() with
  -> panic("VFS: Unable to mount root fs on %s", b);

[akpm@linux-foundation.org: mention that the problem is with the ramdisk, don't print known-to-be-NULL value]
Signed-off-by: P J P <prasad@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 65321547

init/do_mounts_rd.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -342,6 +342,13 @@ static int __init crd_load(int in_fd, int out_fd, decompress_fn deco)
		int result;
		crd_infd = in_fd;
		crd_outfd = out_fd;

		if (!deco) {
		pr_emerg("Invalid ramdisk decompression routine. "
		"Select appropriate config option.\n");
		panic("Could not decompress initial ramdisk image.");
		}

		result = deco(NULL, 0, compr_fill, compr_flush, NULL, NULL, error);
		if (decompress_error)
		result = 1;

Admin message