Commit df2ec764 authored Nov 05, 2019 by Jason Gunthorpe Committed by Linus Torvalds Nov 06, 2019

mm/mmu_notifiers: use the right return code for WARN_ON

The return code from the op callback is actually in _ret, while the
WARN_ON was checking ret which causes it to misfire.

Link: http://lkml.kernel.org/r/20191025175502.GA31127@ziepe.ca


Fixes: 8402ce61 ("mm/mmu_notifiers: check if mmu notifier callbacks are allowed to fail")
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e74540b2

mm/mmu_notifier.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -180,7 +180,7 @@ int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *range)
		mn->ops->invalidate_range_start, _ret,
		!mmu_notifier_range_blockable(range) ? "non-" : "");
		WARN_ON(mmu_notifier_range_blockable(range) \|\|
		ret != -EAGAIN);
		_ret != -EAGAIN);
		ret = _ret;
		}
		}

Admin message