Commit df25f989 authored Jan 05, 2012 by Arnaldo Carvalho de Melo

perf top: Don't update total_period on process_sample



It will be recalculated at __hists__output_resort, to take into account
filters possibly applied by the TUI, etc.

Since we do the percent math only for those entries that will appear on
the TUI instead of for _all_ the entries at decay time, updating it for
each sample makes the entries seem to decay faster when using the
navigation keys (since the screen will be refreshed), as we're not
coalescing the entries that are being batched to be merged at next
resort/decay time, but considering their periods.

Bug introduced in 743eb868.

Reported-by: Ingo Molnar <mingo@elte.hu>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-k0d0rq9a8nqtkqohov8cir72@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 12c14278

tools/perf/builtin-top.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -235,7 +235,6 @@ static struct hist_entry perf_evsel__add_hist_entry(struct perf_evsel evsel,
		if (he == NULL)
		return NULL;

		evsel->hists.stats.total_period += sample->period;
		hists__inc_nr_events(&evsel->hists, PERF_RECORD_SAMPLE);
		return he;
		}

Admin message