Commit df22b5b3 authored Oct 16, 2019 by Ben Dooks (Codethink) Committed by Richard Weinberger Nov 17, 2019

ubifs: Fixed missed le64_to_cpu() in journal



In the ubifs_jnl_write_inode() functon, it calls ubifs_iget()
with xent->inum. The xent->inum is __le64, but the ubifs_iget()
takes native cpu endian.

I think that this should be changed to passing le64_to_cpu(xent->inum)
to fix the following sparse warning:

fs/ubifs/journal.c:902:58: warning: incorrect type in argument 2 (different base types)
fs/ubifs/journal.c:902:58:    expected unsigned long inum
fs/ubifs/journal.c:902:58:    got restricted __le64 [usertype] inum

Fixes: 7959cf3a ("ubifs: journal: Handle xattrs like files")
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent 3cfa4412

fs/ubifs/journal.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -899,7 +899,7 @@ int ubifs_jnl_write_inode(struct ubifs_info c, const struct inode inode)
		fname_name(&nm) = xent->name;
		fname_len(&nm) = le16_to_cpu(xent->nlen);

		xino = ubifs_iget(c->vfs_sb, xent->inum);
		xino = ubifs_iget(c->vfs_sb, le64_to_cpu(xent->inum));
		if (IS_ERR(xino)) {
		err = PTR_ERR(xino);
		ubifs_err(c, "dead directory entry '%s', error %d",

Admin message