Commit df16aaac authored Oct 07, 2017 by Nick Desaulniers Committed by Masahiro Yamada Oct 26, 2017

kbuild: clang: remove crufty HOSTCFLAGS



When compiling with `make CC=clang HOSTCC=clang`, I was seeing warnings
that clang did not recognize -fno-delete-null-pointer-checks for HOSTCC
targets.  These were added in commit 61163efa ("kbuild: LLVMLinux:
Add Kbuild support for building kernel with Clang").

Clang does not support -fno-delete-null-pointer-checks, so adding it to
HOSTCFLAGS if HOSTCC is clang does not make sense.

It's not clear why the other warnings were disabled, and just for
HOSTCFLAGS, but I can remove them, add -Werror to HOSTCFLAGS and compile
with clang just fine.

Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

parent 2c1f4f12

Makefile

+0 −5

Original line number	Diff line number	Diff line
		@@ -365,11 +365,6 @@ HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS)
		HOSTLDFLAGS := $(HOST_LFS_LDFLAGS)
		HOST_LOADLIBES := $(HOST_LFS_LIBS)

		ifeq ($(shell $(HOSTCC) -v 2>&1 \| grep -c "clang version"), 1)
		HOSTCFLAGS += -Wno-unused-value -Wno-unused-parameter \
		-Wno-missing-field-initializers -fno-delete-null-pointer-checks
		endif

		# Make variables (CC, etc...)
		AS = $(CROSS_COMPILE)as
		LD = $(CROSS_COMPILE)ld

Admin message