Commit df16737d authored Jan 08, 2020 by Felix Fietkau Committed by Johannes Berg Jan 15, 2020

cfg80211: fix memory leak in cfg80211_cqm_rssi_update



The per-tid statistics need to be released after the call to rdev_get_station

Cc: stable@vger.kernel.org
Fixes: 8689c051 ("cfg80211: dynamically allocate per-tid stats for station info")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Link: https://lore.kernel.org/r/20200108170630.33680-2-nbd@nbd.name


Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 2a279b34

net/wireless/nl80211.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -10843,6 +10843,7 @@ static int cfg80211_cqm_rssi_update(struct cfg80211_registered_device *rdev,
		if (err)
		return err;

		cfg80211_sinfo_release_content(&sinfo);
		if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_BEACON_SIGNAL_AVG))
		wdev->cqm_config->last_rssi_event_value =
		(s8) sinfo.rx_beacon_signal_avg;

Admin message