Commit df149d02 authored Aug 14, 2010 by Julia Lawall Committed by Jean Delvare Aug 14, 2010

hwmon: (k8temp) Adjust confusing if indentation

Move the if(err) statement after the if into the if branch indicated by its
indentation.  The preceding if(err) test implies that err cannot be nonzero
unless the if branch is taken.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@r disable braces5@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
 cocci.print_main("branch",p4)
 cocci.print_secs("after",p5)
// </smpl>  

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

parent 92fa5bd9

drivers/hwmon/k8temp.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -252,13 +252,14 @@ static int __devinit k8temp_probe(struct pci_dev *pdev,
		&sensor_dev_attr_temp3_input.dev_attr);
		if (err)
		goto exit_remove;
		if (data->sensorsp & SEL_PLACE)
		if (data->sensorsp & SEL_PLACE) {
		err = device_create_file(&pdev->dev,
		&sensor_dev_attr_temp4_input.
		dev_attr);
		if (err)
		goto exit_remove;
		}
		}

		err = device_create_file(&pdev->dev, &dev_attr_name);
		if (err)

Admin message