Commit df08fd4d authored by Shannon Nelson's avatar Shannon Nelson Committed by Jeff Kirsher
Browse files

i40e/i40evf: fix a potential type compare issue 



Rework an if expression to assure there is no type compare problem between
a size and a possible negative number.

Change-ID: I4921fcc96abfcf69490efce020a9e4007f251c99
Reported-by: default avatarHelin Zhang <helin.zhang@intel.com>
Signed-off-by: default avatarShannon Nelson <shannon.nelson@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent bc5166b9

drivers/net/ethernet/intel/i40e/i40e_adminq.h

+1 −2
Original line number Diff line number Diff line
@@ -144,8 +144,7 @@ static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc) 
	if (aq_ret == I40E_ERR_ADMIN_QUEUE_TIMEOUT)

		return -EAGAIN;



	if (aq_rc >= (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])) ||

	    aq_rc < 0)

	if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0]))))

		return -ERANGE;



	return aq_to_posix[aq_rc];

drivers/net/ethernet/intel/i40evf/i40e_adminq.h

+1 −2
Original line number Diff line number Diff line
@@ -144,8 +144,7 @@ static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc) 
	if (aq_ret == I40E_ERR_ADMIN_QUEUE_TIMEOUT)

		return -EAGAIN;



	if (aq_rc >= (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])) ||

	    aq_rc < 0)

	if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0]))))

		return -ERANGE;



	return aq_to_posix[aq_rc];

CRA Git | Maintained and supported by SUSTech CRA and CCSE