Unverified Commit def0aa21 authored Jun 23, 2020 by Vincent Chen Committed by Palmer Dabbelt Jul 09, 2020

kgdb: Move the extern declaration kgdb_has_hit_break() to generic kgdb.h

Currently, only riscv kgdb.c uses the kgdb_has_hit_break() to identify
the kgdb breakpoint. It causes other architectures will encounter the "no
previous prototype" warnings if the compile option has W=1. Moving the
declaration of extern kgdb_has_hit_break() from risc-v kgdb.h to generic
kgdb.h to avoid generating these warnings.

Signed-off-by: Vincent Chen <vincent.chen@sifive.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>

parent f7fc7528

arch/riscv/include/asm/kgdb.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -19,7 +19,6 @@

		#ifndef __ASSEMBLY__

		extern int kgdb_has_hit_break(unsigned long addr);
		extern unsigned long kgdb_compiled_break;

		static inline void arch_kgdb_breakpoint(void)

include/linux/kgdb.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -325,6 +325,7 @@ extern int kgdb_hex2mem(char buf, char mem, int count);

		extern int kgdb_isremovedbreak(unsigned long addr);
		extern void kgdb_schedule_breakpoint(void);
		extern int kgdb_has_hit_break(unsigned long addr);

		extern int
		kgdb_handle_exception(int ex_vector, int signo, int err_code,

Admin message