xfs: Check for -ENOATTR or -EEXIST (deed9512) · Commits · 戴 / test

Delayed operations cannot return error codes. So we must check for these conditions first before starting set or remove operations Signed-off-by:

fs/xfs/libxfs/xfs_attr.c

+13 −0

Original line number	Diff line number	Diff line
		@@ -404,6 +404,15 @@ xfs_attr_set(
		args->total, 0, quota_flags);
		if (error)
		goto out_trans_cancel;

		error = xfs_has_attr(args);
		if (error == -EEXIST && (args->attr_flags & XATTR_CREATE))
		goto out_trans_cancel;
		if (error == -ENOATTR && (args->attr_flags & XATTR_REPLACE))
		goto out_trans_cancel;
		if (error != -ENOATTR && error != -EEXIST)
		goto out_trans_cancel;

		error = xfs_attr_set_args(args);
		if (error)
		goto out_trans_cancel;
		@@ -411,6 +420,10 @@ xfs_attr_set(
		if (!args->trans)
		goto out_unlock;
		} else {
		error = xfs_has_attr(args);
		if (error != -EEXIST)
		goto out_trans_cancel;

		error = xfs_attr_remove_args(args);
		if (error)
		goto out_trans_cancel;