Commit deea9f5f authored Sep 21, 2019 by Hugh Cole-Baker Committed by Heiko Stuebner Oct 04, 2019

arm64: dts: rockchip: fix Rockpro64 RK808 interrupt line

Fix the pinctrl and interrupt specifier for RK808 to use GPIO3_B2. On the
Rockpro64 schematic [1] page 16, it shows GPIO3_B2 used for the interrupt
line PMIC_INT_L from the RK808, and there's a note which translates as:
"PMU termination GPIO1_C5 changed to this".

Tested by setting an RTC wakealarm and checking /proc/interrupts counters.
Without this patch, neither the rockchip_gpio_irq counter for the RK808,
nor the RTC alarm counter increment when the alarm time is reached.
With this patch, both interrupt counters increment by 1 as expected.

[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf



Fixes: e4f3fb49 ("arm64: dts: rockchip: add initial dts support for Rockpro64")
Signed-off-by: Hugh Cole-Baker <sigmaris@gmail.com>
Link: https://lore.kernel.org/r/20190921131457.36258-1-sigmaris@gmail.com


Signed-off-by: Heiko Stuebner <heiko@sntech.de>

parent 54ecb8f7

arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts

+3 −3

Original line number	Diff line number	Diff line
		@@ -247,8 +247,8 @@
		rk808: pmic@1b {
		compatible = "rockchip,rk808";
		reg = <0x1b>;
		interrupt-parent = <&gpio1>;
		interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
		interrupt-parent = <&gpio3>;
		interrupts = <10 IRQ_TYPE_LEVEL_LOW>;
		#clock-cells = <1>;
		clock-output-names = "xin32k", "rk808-clkout2";
		pinctrl-names = "default";
		@@ -574,7 +574,7 @@

		pmic {
		pmic_int_l: pmic-int-l {
		rockchip,pins = <1 RK_PC5 RK_FUNC_GPIO &pcfg_pull_up>;
		rockchip,pins = <3 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
		};

		vsel1_gpio: vsel1-gpio {

Admin message