Commit dec17b74 authored by Jesper Juhl's avatar Jesper Juhl Committed by David S. Miller
Browse files

Remove redundant linux/version.h includes from net/ 



It was suggested by "make versioncheck" that the follwing includes of
linux/version.h are redundant:

  /home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed.
  /home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed.
  /home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed.
  /home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed.
  /home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed.

and it seems that it is right.

Beyond manually inspecting the source files I also did a few build
tests with various configs to confirm that including the header in
those files is indeed not needed.

Here's a patch to remove the pointless includes.

Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Acked-by: default avatarJozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3b182d7d

net/caif/caif_dev.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -11,7 +11,6 @@ 




#define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__

#define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__





#include <linux/version.h>

#include <linux/kernel.h>

#include <linux/kernel.h>

#include <linux/if_arp.h>

#include <linux/if_arp.h>

#include <linux/net.h>

#include <linux/net.h>

net/caif/chnl_net.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -7,7 +7,6 @@ 




#define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__

#define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__





#include <linux/version.h>

#include <linux/fs.h>

#include <linux/fs.h>

#include <linux/hardirq.h>

#include <linux/hardirq.h>

#include <linux/init.h>

#include <linux/init.h>

net/ipv4/gre.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -16,7 +16,6 @@ 
#include <linux/skbuff.h>

#include <linux/skbuff.h>

#include <linux/in.h>

#include <linux/in.h>

#include <linux/netdevice.h>

#include <linux/netdevice.h>

#include <linux/version.h>

#include <linux/spinlock.h>

#include <linux/spinlock.h>

#include <net/protocol.h>

#include <net/protocol.h>

#include <net/gre.h>

#include <net/gre.h>

net/netfilter/ipset/ip_set_core.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -17,7 +17,6 @@ 
#include <linux/spinlock.h>

#include <linux/spinlock.h>

#include <linux/netlink.h>

#include <linux/netlink.h>

#include <linux/rculist.h>

#include <linux/rculist.h>

#include <linux/version.h>

#include <net/netlink.h>

#include <net/netlink.h>





#include <linux/netfilter.h>

#include <linux/netfilter.h>

net/netfilter/xt_set.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -13,7 +13,6 @@ 




#include <linux/module.h>

#include <linux/module.h>

#include <linux/skbuff.h>

#include <linux/skbuff.h>

#include <linux/version.h>





#include <linux/netfilter/x_tables.h>

#include <linux/netfilter/x_tables.h>

#include <linux/netfilter/xt_set.h>

#include <linux/netfilter/xt_set.h>

CRA Git | Maintained and supported by SUSTech CRA and CCSE