Commit deab72d3 authored Mar 16, 2011 by Bob Peterson Committed by Steven Whitehouse Apr 18, 2011

GFS2: write_end error path fails to unlock transaction lock



I did an audit of gfs2's transaction glock for bugzilla bug
658619 and ran across this:

In function gfs2_write_end, in the unlikely event that
gfs2_meta_inode_buffer returns an error, the code may forget
to unlock the transaction lock because the "failed" label
appears after the call to function gfs2_trans_end.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

parent a1b49cb7

fs/gfs2/aops.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -884,8 +884,8 @@ static int gfs2_write_end(struct file file, struct address_space mapping,
		}

		brelse(dibh);
		gfs2_trans_end(sdp);
		failed:
		gfs2_trans_end(sdp);
		if (al) {
		gfs2_inplace_release(ip);
		gfs2_quota_unlock(ip);

Admin message