firmware: qcom_scm: make it explicitly non-modular (dea85242) · Commits · 戴 / test

The Kconfig currently controlling compilation of this code is: drivers/firmware/Kconfig:config QCOM_SCM drivers/firmware/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_init was not in use by this code, the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Cc: Andy Gross <andy.gross@linaro.org> Cc: David Brown <david.brown@linaro.org> Cc: linux-arm-msm@vger.kernel.org Cc: linux-soc@vger.kernel.org Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by:

Andy Gross <andy.gross@linaro.org>

drivers/firmware/qcom_scm.c

+5 −14

Original line number	Diff line number	Diff line
		/* Copyright (c) 2010,2015, The Linux Foundation. All rights reserved.
		/*
		* Qualcomm SCM driver
		*
		* Copyright (c) 2010,2015, The Linux Foundation. All rights reserved.
		* Copyright (C) 2015 Linaro Ltd.
		*
		* This program is free software; you can redistribute it and/or modify
		@@ -12,7 +15,7 @@
		*
		*/
		#include <linux/platform_device.h>
		#include <linux/module.h>
		#include <linux/init.h>
		#include <linux/cpumask.h>
		#include <linux/export.h>
		#include <linux/dma-mapping.h>
		@@ -376,8 +379,6 @@ static const struct of_device_id qcom_scm_dt_match[] = {
		{}
		};

		MODULE_DEVICE_TABLE(of, qcom_scm_dt_match);

		static struct platform_driver qcom_scm_driver = {
		.driver = {
		.name = "qcom_scm",
		@@ -414,14 +415,4 @@ static int __init qcom_scm_init(void)

		return platform_driver_register(&qcom_scm_driver);
		}

		subsys_initcall(qcom_scm_init);

		static void __exit qcom_scm_exit(void)
		{
		platform_driver_unregister(&qcom_scm_driver);
		}
		module_exit(qcom_scm_exit);

		MODULE_DESCRIPTION("Qualcomm SCM driver");
		MODULE_LICENSE("GPL v2");

Admin message