Commit dea37e82 authored Jun 01, 2017 by James Smart Committed by Martin K. Petersen Jun 12, 2017

scsi: lpfc: Fix PRLI retry handling when target rejects it.



The nvmet driver was rejecting the initiator's PRLI because its reg_rpi
for the PLOGI was still outstanding.  The initiator would resend the
PRLI without delay and get the same answer.  The PRLI retries would
exhaust causing the nvme initiator to set the nvmet ndlp to UNMAPPED.

The driver's lpfc_els_retry handler did not have a policy for an LS_RJT
with explanation CMD_IN_PROGRESS for PRLI or NVME_PRLI.  This caused the
delay to remain at 0 but retry set 1.

Fix: When the ELS response is LS_RJT, TPC and the command was PRLI or
NVME_PRLI, just set the delay to 1000 mS to get a 1 second delay on the
PRLI retry.  This was enough to allow the REG_RPI to complete at the
target.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent e92974f6

drivers/scsi/lpfc/lpfc_els.c

+14 −3

Original line number	Diff line number	Diff line
		@@ -3332,6 +3332,19 @@ lpfc_els_retry(struct lpfc_hba phba, struct lpfc_iocbq cmdiocb,
		*/
		switch (stat.un.b.lsRjtRsnCode) {
		case LSRJT_UNABLE_TPC:
		/* The driver has a VALID PLOGI but the rport has
		* rejected the PRLI - can't do it now. Delay
		* for 1 second and try again - don't care about
		* the explanation.
		*/
		if (cmd == ELS_CMD_PRLI \|\| cmd == ELS_CMD_NVMEPRLI) {
		delay = 1000;
		maxretry = lpfc_max_els_tries + 1;
		retry = 1;
		break;
		}

		/* Legacy bug fix code for targets with PLOGI delays. */
		if (stat.un.b.lsRjtRsnCodeExp ==
		LSEXP_CMD_IN_PROGRESS) {
		if (cmd == ELS_CMD_PLOGI) {
		@@ -3350,9 +3363,7 @@ lpfc_els_retry(struct lpfc_hba phba, struct lpfc_iocbq cmdiocb,
		retry = 1;
		break;
		}
		if ((cmd == ELS_CMD_PLOGI) \|\|
		(cmd == ELS_CMD_PRLI) \|\|
		(cmd == ELS_CMD_NVMEPRLI)) {
		if (cmd == ELS_CMD_PLOGI) {
		delay = 1000;
		maxretry = lpfc_max_els_tries + 1;
		retry = 1;

Admin message