[GFS2] Data corruption fix (de986e85) · Commits · 戴 / test

* GFS2 has been using i_cache array to store its indirect meta blocks. Its flush routine doesn't correctly clean up all the entries. The problem would show while multiple nodes do simultaneous writes to the same file. Upon glock exclusive lock transfer, if the file is a sparse file with large file size where the indirect meta blocks span multiple array entries with "zero" entries in between. The flush routine prematurely stops the flushing that leaves old (stale) entries around. This leads to several nasty issues, including data corruption. * Fix gfs2_get_block_noalloc checking to correctly return EIO upon unmapped buffer. Signed-off-by:

Wendy Cheng <wcheng@redhat.com> Signed-off-by:

Steven Whitehouse <swhiteho@redhat.com>

fs/gfs2/meta_io.c

+4 −4

Original line number	Original line	Diff line number	Diff line
	@@ -374,11 +374,11 @@ void gfs2_meta_cache_flush(struct gfs2_inode *ip)

	for (x = 0; x < GFS2_MAX_META_HEIGHT; x++) {		for (x = 0; x < GFS2_MAX_META_HEIGHT; x++) {
	bh_slot = &ip->i_cache[x];		bh_slot = &ip->i_cache[x];
	if (!*bh_slot)		if (*bh_slot) {
	break;
	brelse(*bh_slot);		brelse(*bh_slot);
	*bh_slot = NULL;		*bh_slot = NULL;
	}		}
			}

	spin_unlock(&ip->i_spin);		spin_unlock(&ip->i_spin);
	}		}

fs/gfs2/ops_address.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -90,7 +90,7 @@ static int gfs2_get_block_noalloc(struct inode *inode, sector_t lblock,
	error = gfs2_block_map(inode, lblock, 0, bh_result);		error = gfs2_block_map(inode, lblock, 0, bh_result);
	if (error)		if (error)
	return error;		return error;
	if (bh_result->b_blocknr == 0)		if (!buffer_mapped(bh_result))
	return -EIO;		return -EIO;
	return 0;		return 0;
	}		}

Admin message