Commit de92fc97 authored Dec 17, 2013 by Gao feng Committed by Eric Paris Jan 13, 2014

audit: fix incorrect set of audit_sock



NETLINK_CB(skb).sk is the socket of user space process,
netlink_unicast in kauditd_send_skb wants the kernel
side socket. Since the sk_state of audit netlink socket
is not NETLINK_CONNECTED, so the netlink_getsockbyportid
doesn't return -ECONNREFUSED.

And the socket of userspace process can be released anytime,
so the audit_sock may point to invalid socket.

this patch sets the audit_sock to the kernel side audit
netlink socket.

Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Acked-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>

parent 11ee39eb

kernel/audit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -821,7 +821,7 @@ static int audit_receive_msg(struct sk_buff skb, struct nlmsghdr nlh)
		audit_log_config_change("audit_pid", new_pid, audit_pid, 1);
		audit_pid = new_pid;
		audit_nlk_portid = NETLINK_CB(skb).portid;
		audit_sock = NETLINK_CB(skb).sk;
		audit_sock = skb->sk;
		}
		if (s.mask & AUDIT_STATUS_RATE_LIMIT) {
		err = audit_set_rate_limit(s.rate_limit);

Admin message