Commit de8d1810 authored May 22, 2015 by Geert Uytterhoeven Committed by Thomas Gleixner May 22, 2015

genirq: Set IRQCHIP_SKIP_SET_WAKE for no_irq_chip



If no_irq_chip is used for wake up (e.g. gpio-keys with a simple GPIO
controller), the following warning is printed on resume from s2ram:

    WANING: CPU: 0 PID: 1046 at kernel/irq/manage.c:537 irq_set_irq_wake+0x9c/0xf8()
    Unbalanced IRQ 113 wake disable

This happens because no_irq_chip does not implement
irq_chip.irq_set_wake(), causing set_irq_wake_real() to return -ENXIO,
and irq_set_irq_wake() to reset the wake_depth to zero.

Set IRQCHIP_SKIP_SET_WAKE to indicate that irq_chip.irq_set_wake() is
not implemented.

Cfr. commit 10a50f1a ("genirq: Set IRQCHIP_SKIP_SET_WAKE flag
for dummy_irq_chip").

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Roger Quadros <rogerq@ti.com>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Link: http://lkml.kernel.org/r/1432281529-23325-1-git-send-email-geert%2Brenesas@glider.be


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent e1a96fb8

kernel/irq/dummychip.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -42,6 +42,7 @@ struct irq_chip no_irq_chip = {
		.irq_enable = noop,
		.irq_disable = noop,
		.irq_ack = ack_bad,
		.flags = IRQCHIP_SKIP_SET_WAKE,
		};

		/*

Admin message