Commit de66aa63 authored Jan 27, 2013 by Johan Hedberg Committed by Gustavo Padovan Feb 01, 2013

Bluetooth: Store UUIDs in the same order that they were added



We should be encoding UUIDs to the EIR data in the same order that they
were added to the kernel, i.e. each UUID should be added to the end of
the UUIDs list. This patch fixes the issue by using list_add_tail
instead of list_add for storing the UUIDs.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

parent c331997b

net/bluetooth/mgmt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1330,7 +1330,7 @@ static int add_uuid(struct sock sk, struct hci_dev hdev, void *data, u16 len)
		memcpy(uuid->uuid, cp->uuid, 16);
		uuid->svc_hint = cp->svc_hint;

		list_add(&uuid->list, &hdev->uuids);
		list_add_tail(&uuid->list, &hdev->uuids);

		err = update_class(hdev);
		if (err < 0)

Admin message