Commit de6476f5 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (10408): v4l2: fix incorrect hue range check 



A hue of -128 was rejected due to an incorrect range check, which was
faithfully copy-and-pasted into four drivers...

Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent d9ddd3b0

drivers/media/video/cx18/cx18-av-core.c

+1 −1
Original line number Diff line number Diff line
@@ -548,7 +548,7 @@ static int set_v4lctrl(struct cx18 *cx, struct v4l2_control *ctrl) 
		break;



	case V4L2_CID_HUE:

		if (ctrl->value < -127 || ctrl->value > 127) {

		if (ctrl->value < -128 || ctrl->value > 127) {

			CX18_ERR("invalid hue setting %d\n", ctrl->value);

			return -ERANGE;

		}

drivers/media/video/cx25840/cx25840-core.c

+1 −1
Original line number Diff line number Diff line
@@ -763,7 +763,7 @@ static int cx25840_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl) 
		break;



	case V4L2_CID_HUE:

		if (ctrl->value < -127 || ctrl->value > 127) {

		if (ctrl->value < -128 || ctrl->value > 127) {

			v4l_err(client, "invalid hue setting %d\n", ctrl->value);

			return -ERANGE;

		}

drivers/media/video/saa7115.c

+1 −1
Original line number Diff line number Diff line
@@ -778,7 +778,7 @@ static int saa711x_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl) 
		break;



	case V4L2_CID_HUE:

		if (ctrl->value < -127 || ctrl->value > 127) {

		if (ctrl->value < -128 || ctrl->value > 127) {

			v4l2_err(sd, "invalid hue setting %d\n", ctrl->value);

			return -ERANGE;

		}

drivers/media/video/saa717x.c

+1 −1
Original line number Diff line number Diff line
@@ -931,7 +931,7 @@ static int saa717x_s_ctrl(struct v4l2_subdev *sd, struct v4l2_control *ctrl) 
		break;



	case V4L2_CID_HUE:

		if (ctrl->value < -127 || ctrl->value > 127) {

		if (ctrl->value < -128 || ctrl->value > 127) {

			v4l2_err(sd, "invalid hue setting %d\n", ctrl->value);

			return -ERANGE;

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE