Commit de60f5f1 authored by Eric B Munson's avatar Eric B Munson Committed by Linus Torvalds
Browse files

mm: introduce VM_LOCKONFAULT 



The cost of faulting in all memory to be locked can be very high when
working with large mappings.  If only portions of the mapping will be used
this can incur a high penalty for locking.

For the example of a large file, this is the usage pattern for a large
statical language model (probably applies to other statical or graphical
models as well).  For the security example, any application transacting in
data that cannot be swapped out (credit card data, medical records, etc).

This patch introduces the ability to request that pages are not
pre-faulted, but are placed on the unevictable LRU when they are finally
faulted in.  The VM_LOCKONFAULT flag will be used together with VM_LOCKED
and has no effect when set without VM_LOCKED.  Setting the VM_LOCKONFAULT
flag for a VMA will cause pages faulted into that VMA to be added to the
unevictable LRU when they are faulted or if they are already present, but
will not cause any missing pages to be faulted in.

Exposing this new lock state means that we cannot overload the meaning of
the FOLL_POPULATE flag any longer.  Prior to this patch it was used to
mean that the VMA for a fault was locked.  This means we need the new
FOLL_MLOCK flag to communicate the locked state of a VMA.  FOLL_POPULATE
will now only control if the VMA should be populated and in the case of
VM_LOCKONFAULT, it will not be set.

Signed-off-by: default avatarEric B Munson <emunson@akamai.com>
Acked-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a8ca5d0e

include/linux/mm.h

+5 −0
Original line number Diff line number Diff line
@@ -139,6 +139,7 @@ extern unsigned int kobjsize(const void *objp); 


#define VM_DONTCOPY	0x00020000      /* Do not copy this vma on fork */

#define VM_DONTEXPAND	0x00040000	/* Cannot expand with mremap() */

#define VM_LOCKONFAULT	0x00080000	/* Lock the pages covered when they are faulted in */

#define VM_ACCOUNT	0x00100000	/* Is a VM accounted object */

#define VM_NORESERVE	0x00200000	/* should the VM suppress accounting */

#define VM_HUGETLB	0x00400000	/* Huge TLB Page VM */
@@ -202,6 +203,9 @@ extern unsigned int kobjsize(const void *objp); 
/* This mask defines which mm->def_flags a process can inherit its parent */

#define VM_INIT_DEF_MASK	VM_NOHUGEPAGE



/* This mask is used to clear all the VMA flags used by mlock */

#define VM_LOCKED_CLEAR_MASK	(~(VM_LOCKED | VM_LOCKONFAULT))



/*

 * mapping from the currently active vm_flags protection bits (the

 * low four bits) to a page protection mask..
@@ -2137,6 +2141,7 @@ static inline struct page *follow_page(struct vm_area_struct *vma, 
#define FOLL_NUMA	0x200	/* force NUMA hinting page fault */

#define FOLL_MIGRATION	0x400	/* wait for page to replace migration entry */

#define FOLL_TRIED	0x800	/* a retry, previous pass started an IO */

#define FOLL_MLOCK	0x1000	/* lock present pages */



typedef int (*pte_fn_t)(pte_t *pte, pgtable_t token, unsigned long addr,

			void *data);

kernel/fork.c

+2 −1
Original line number Diff line number Diff line
@@ -454,7 +454,8 @@ static int dup_mmap(struct mm_struct *mm, struct mm_struct *oldmm) 
		tmp->vm_mm = mm;

		if (anon_vma_fork(tmp, mpnt))

			goto fail_nomem_anon_vma_fork;

		tmp->vm_flags &= ~(VM_LOCKED|VM_UFFD_MISSING|VM_UFFD_WP);

		tmp->vm_flags &=

			~(VM_LOCKED|VM_LOCKONFAULT|VM_UFFD_MISSING|VM_UFFD_WP);

		tmp->vm_next = tmp->vm_prev = NULL;

		tmp->vm_userfaultfd_ctx = NULL_VM_UFFD_CTX;

		file = tmp->vm_file;

mm/debug.c

+1 −0
Original line number Diff line number Diff line
@@ -125,6 +125,7 @@ static const struct trace_print_flags vmaflags_names[] = { 
	{VM_GROWSDOWN,			"growsdown"	},

	{VM_PFNMAP,			"pfnmap"	},

	{VM_DENYWRITE,			"denywrite"	},

	{VM_LOCKONFAULT,		"lockonfault"	},

	{VM_LOCKED,			"locked"	},

	{VM_IO,				"io"		},

	{VM_SEQ_READ,			"seqread"	},

mm/gup.c

+8 −2
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ retry: 
		 */

		mark_page_accessed(page);

	}

	if ((flags & FOLL_POPULATE) && (vma->vm_flags & VM_LOCKED)) {

	if ((flags & FOLL_MLOCK) && (vma->vm_flags & VM_LOCKED)) {

		/*

		 * The preliminary mapping check is mainly to avoid the

		 * pointless overhead of lock_page on the ZERO_PAGE
@@ -299,6 +299,9 @@ static int faultin_page(struct task_struct *tsk, struct vm_area_struct *vma, 
	unsigned int fault_flags = 0;

	int ret;



	/* mlock all present pages, but do not fault in new pages */

	if ((*flags & (FOLL_POPULATE | FOLL_MLOCK)) == FOLL_MLOCK)

		return -ENOENT;

	/* For mm_populate(), just skip the stack guard page. */

	if ((*flags & FOLL_POPULATE) &&

			(stack_guard_page_start(vma, address) ||
@@ -890,7 +893,10 @@ long populate_vma_page_range(struct vm_area_struct *vma, 
	VM_BUG_ON_VMA(end   > vma->vm_end, vma);

	VM_BUG_ON_MM(!rwsem_is_locked(&mm->mmap_sem), mm);



	gup_flags = FOLL_TOUCH | FOLL_POPULATE;

	gup_flags = FOLL_TOUCH | FOLL_POPULATE | FOLL_MLOCK;

	if (vma->vm_flags & VM_LOCKONFAULT)

		gup_flags &= ~FOLL_POPULATE;



	/*

	 * We want to touch writable mappings with a write fault in order

	 * to break COW, except for shared mappings because these don't COW

mm/huge_memory.c

+1 −1
Original line number Diff line number Diff line
@@ -1307,7 +1307,7 @@ struct page *follow_trans_huge_pmd(struct vm_area_struct *vma, 
					  pmd, _pmd,  1))

			update_mmu_cache_pmd(vma, addr, pmd);

	}

	if ((flags & FOLL_POPULATE) && (vma->vm_flags & VM_LOCKED)) {

	if ((flags & FOLL_MLOCK) && (vma->vm_flags & VM_LOCKED)) {

		if (page->mapping && trylock_page(page)) {

			lru_add_drain();

			if (page->mapping)

CRA Git | Maintained and supported by SUSTech CRA and CCSE