Commit de4fcbad authored by Johannes Berg's avatar Johannes Berg
Browse files

cfg80211: avoid using default in interface type switch 



Most code avoids having a default case in interface type switch
statements already, to make it easier to find places that need
to be extended. Change the code in the __cfg80211_leave() and
nl80211_key_allowed() functions to not have a default case.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 579a05f2

net/wireless/core.c

+13 −1
Original line number Diff line number Diff line
@@ -869,7 +869,19 @@ void __cfg80211_leave(struct cfg80211_registered_device *rdev, 
	case NL80211_IFTYPE_P2P_GO:

		__cfg80211_stop_ap(rdev, dev, true);

		break;

	default:

	case NL80211_IFTYPE_WDS:

		/* must be handled by mac80211/driver, has no APIs */

		break;

	case NL80211_IFTYPE_P2P_DEVICE:

		/* cannot happen, has no netdev */

		break;

	case NL80211_IFTYPE_AP_VLAN:

	case NL80211_IFTYPE_MONITOR:

		/* nothing to do */

		break;

	case NL80211_IFTYPE_UNSPECIFIED:

	case NUM_NL80211_IFTYPES:

		/* invalid */

		break;

	}

}

net/wireless/nl80211.c

+5 −1
Original line number Diff line number Diff line
@@ -884,7 +884,11 @@ static int nl80211_key_allowed(struct wireless_dev *wdev) 
		if (!wdev->current_bss)

			return -ENOLINK;

		break;

	default:

	case NL80211_IFTYPE_UNSPECIFIED:

	case NL80211_IFTYPE_MONITOR:

	case NL80211_IFTYPE_P2P_DEVICE:

	case NL80211_IFTYPE_WDS:

	case NUM_NL80211_IFTYPES:

		return -EINVAL;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE