Commit de477254 authored by Paul Gortmaker's avatar Paul Gortmaker
Browse files

include: replace linux/module.h with "struct module" wherever possible 



The <linux/module.h> pretty much brings in the kitchen sink along
with it, so it should be avoided wherever reasonably possible in
terms of being included from other commonly used <linux/something.h>
files, as it results in a measureable increase on compile times.

The worst culprit was probably device.h since it is used everywhere.
This file also had an implicit dependency/usage of mutex.h which was
masked by module.h, and is also fixed here at the same time.

There are over a dozen other headers that simply declare the
struct instead of pulling in the whole file, so follow their lead
and simply make it a few more.

Most of the implicit dependencies on module.h being present by
these headers pulling it in have been now weeded out, so we can
finally make this change with hopefully minimal breakage.

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent eb5589a8

include/drm/drmP.h

+2 −1
Original line number Diff line number Diff line
@@ -42,7 +42,6 @@ 
 * can build the DRM (part of PI DRI). 4/21/2000 S + B */

#include <asm/current.h>

#endif				/* __alpha__ */

#include <linux/module.h>

#include <linux/kernel.h>

#include <linux/miscdevice.h>

#include <linux/fs.h>
@@ -80,6 +79,8 @@ 
#define __OS_HAS_AGP (defined(CONFIG_AGP) || (defined(CONFIG_AGP_MODULE) && defined(MODULE)))

#define __OS_HAS_MTRR (defined(CONFIG_MTRR))



struct module;



struct drm_file;

struct drm_device;

include/linux/blkdev.h

+1 −1
Original line number Diff line number Diff line
@@ -14,7 +14,6 @@ 
#include <linux/wait.h>

#include <linux/mempool.h>

#include <linux/bio.h>

#include <linux/module.h>

#include <linux/stringify.h>

#include <linux/gfp.h>

#include <linux/bsg.h>
@@ -22,6 +21,7 @@ 


#include <asm/scatterlist.h>



struct module;

struct scsi_ioctl_command;



struct request_queue;

include/linux/cpuidle.h

+2 −1
Original line number Diff line number Diff line
@@ -13,7 +13,6 @@ 


#include <linux/percpu.h>

#include <linux/list.h>

#include <linux/module.h>

#include <linux/kobject.h>

#include <linux/completion.h>
@@ -21,6 +20,8 @@ 
#define CPUIDLE_NAME_LEN	16

#define CPUIDLE_DESC_LEN	32



struct module;



struct cpuidle_device;

include/linux/device.h

+2 −1
Original line number Diff line number Diff line
@@ -20,7 +20,7 @@ 
#include <linux/lockdep.h>

#include <linux/compiler.h>

#include <linux/types.h>

#include <linux/module.h>

#include <linux/mutex.h>

#include <linux/pm.h>

#include <linux/atomic.h>

#include <asm/device.h>
@@ -29,6 +29,7 @@ struct device; 
struct device_private;

struct device_driver;

struct driver_private;

struct module;

struct class;

struct subsys_private;

struct bus_type;

include/linux/firmware.h

+1 −1
Original line number Diff line number Diff line 
#ifndef _LINUX_FIRMWARE_H

#define _LINUX_FIRMWARE_H



#include <linux/module.h>

#include <linux/types.h>

#include <linux/compiler.h>

#include <linux/gfp.h>
@@ -15,6 +14,7 @@ struct firmware { 
	struct page **pages;

};



struct module;

struct device;



struct builtin_fw {

CRA Git | Maintained and supported by SUSTech CRA and CCSE