Commit de459215 authored Jul 14, 2006 by Kirill Korotaev Committed by Linus Torvalds Jul 14, 2006

[PATCH] struct file leakage



2.6.16 leaks like hell. While testing, I found massive leakage
(reproduced in openvz) in:

*filp
*size-4096

And 1 object leaks in
*size-32
*size-64
*size-128

It is the fix for the first one.  filp leaks in the bowels of namei.c.

Seems, size-4096 is file table leaking in expand_fdtables.

I have no idea what are the rest and why they show only accompanying
another leaks.  Some debugging structs?

[akpm@osdl.org, Trond: remove the IS_ERR() check]
Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: Kirill Korotaev <dev@openvz.org>
Cc: <stable@kernel.org>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 9ee8ab9f

fs/namei.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -1712,8 +1712,14 @@ do_link:
		if (error)
		goto exit_dput;
		error = __do_follow_link(&path, nd);
		if (error)
		if (error) {
		/* Does someone understand code flow here? Or it is only
		* me so stupid? Anathema to whoever designed this non-sense
		* with "intent.open".
		*/
		release_open_intent(nd);
		return error;
		}
		nd->flags &= ~LOOKUP_PARENT;
		if (nd->last_type == LAST_BIND)
		goto ok;

Admin message