Commit de4334f7 authored Jul 13, 2020 by Lee Jones Committed by Linus Walleij Jul 16, 2020

pinctrl: pinctrl-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI



Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI,
'struct amd_gpio_acpi_match' becomes defined but unused.

Fixes the following W=1 kernel build warning(s):

 drivers/pinctrl/pinctrl-amd.c:959:36: warning: ‘amd_gpio_acpi_match’ defined but not used [-Wunused-const-variable=]
 959 | static const struct acpi_device_id amd_gpio_acpi_match[] = {

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Cc: Ken Xue <Ken.Xue@amd.com>
Cc: "Wu, Jeff" <Jeff.Wu@amd.com>
Cc: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
Cc: Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20200713144930.1034632-26-lee.jones@linaro.org


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 192b752e

drivers/pinctrl/pinctrl-amd.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -956,12 +956,14 @@ static int amd_gpio_remove(struct platform_device *pdev)
		return 0;
		}

		#ifdef CONFIG_ACPI
		static const struct acpi_device_id amd_gpio_acpi_match[] = {
		{ "AMD0030", 0 },
		{ "AMDI0030", 0},
		{ },
		};
		MODULE_DEVICE_TABLE(acpi, amd_gpio_acpi_match);
		#endif

		static struct platform_driver amd_gpio_driver = {
		.driver = {

Admin message