Commit de40ccef authored Nov 17, 2017 by Dave Young Committed by Linus Torvalds Nov 17, 2017

kdump: print a message in case parse_crashkernel_mem resulted in zero bytes

parse_crashkernel_mem() silently returns if we get zero bytes in the
parsing function.  It is useful for debugging to add a message,
especially if the kernel cannot boot correctly.

Add a pr_info instead of pr_warn because it is expected behavior for
size = 0, eg.  crashkernel=2G-4G:128M, size will be 0 in case system
memory is less than 2G.

Link: http://lkml.kernel.org/r/20171114080129.GA6115@dhcp-128-65.nay.redhat.com


Signed-off-by: Dave Young <dyoung@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Bhupesh Sharma <bhsharma@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 42691579

kernel/crash_core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -108,7 +108,8 @@ static int __init parse_crashkernel_mem(char *cmdline,
		return -EINVAL;
		}
		}
		}
		} else
		pr_info("crashkernel size resulted in zero bytes\n");

		return 0;
		}

Admin message