Commit de3ef1eb authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

PM / core: Drop run_wake flag from struct dev_pm_info 



The run_wake flag in struct dev_pm_info is used to indicate whether
or not the device is capable of generating remote wakeup signals at
run time (or in the system working state), but the distinction
between runtime remote wakeup and system wakeup signaling has always
been rather artificial.  The only practical reason for it to exist
at the core level was that ACPI and PCI treated those two cases
differently, but that's not the case any more after recent changes.

For this reason, get rid of the run_wake flag and, when applicable,
use device_set_wakeup_capable() and device_can_wakeup() instead of
device_set_run_wake() and device_run_wake(), respectively.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 0847684c

Documentation/power/runtime_pm.txt

+2 −5
Original line number Diff line number Diff line
@@ -105,9 +105,9 @@ knows what to do to handle the device). 


In particular, if the driver requires remote wakeup capability (i.e. hardware

mechanism allowing the device to request a change of its power state, such as

PCI PME) for proper functioning and device_run_wake() returns 'false' for the

PCI PME) for proper functioning and device_can_wakeup() returns 'false' for the

device, then ->runtime_suspend() should return -EBUSY.  On the other hand, if

device_run_wake() returns 'true' for the device and the device is put into a

device_can_wakeup() returns 'true' for the device and the device is put into a

low-power state during the execution of the suspend callback, it is expected

that remote wakeup will be enabled for the device.  Generally, remote wakeup

should be enabled for all input devices put into low-power states at run time.
@@ -253,9 +253,6 @@ defined in include/linux/pm.h: 
      being executed for that device and it is not practical to wait for the

      suspend to complete; means "start a resume as soon as you've suspended"



  unsigned int run_wake;

    - set if the device is capable of generating runtime wake-up events



  enum rpm_status runtime_status;

    - the runtime PM status of the device; this field's initial value is

      RPM_SUSPENDED, which means that each device is initially regarded by the

drivers/acpi/pci_root.c

+2 −3
Original line number Diff line number Diff line
@@ -608,8 +608,7 @@ static int acpi_pci_root_add(struct acpi_device *device, 
		pcie_no_aspm();



	pci_acpi_add_bus_pm_notifier(device);

	if (device->wakeup.flags.valid)

		device_set_run_wake(root->bus->bridge, true);

	device_set_wakeup_capable(root->bus->bridge, device->wakeup.flags.valid);



	if (hotadd) {

		pcibios_resource_survey_bus(root->bus);
@@ -649,7 +648,7 @@ static void acpi_pci_root_remove(struct acpi_device *device) 
	pci_stop_root_bus(root->bus);



	pci_ioapic_remove(root);

	device_set_run_wake(root->bus->bridge, false);

	device_set_wakeup_capable(root->bus->bridge, false);

	pci_acpi_remove_bus_pm_notifier(device);



	pci_remove_root_bus(root->bus);

drivers/pci/pci-acpi.c

+1 −4
Original line number Diff line number Diff line
@@ -738,7 +738,6 @@ static void pci_acpi_setup(struct device *dev) 
		return;



	device_set_wakeup_capable(dev, true);

	device_set_run_wake(dev, true);

	acpi_pci_wakeup(pci_dev, false);

}
@@ -750,10 +749,8 @@ static void pci_acpi_cleanup(struct device *dev) 
		return;



	pci_acpi_remove_pm_notifier(adev);

	if (adev->wakeup.flags.valid) {

	if (adev->wakeup.flags.valid)

		device_set_wakeup_capable(dev, false);

		device_set_run_wake(dev, false);

	}

}



static bool pci_acpi_bus_match(struct device *dev)

drivers/pci/pci.c

+3 −3
Original line number Diff line number Diff line
@@ -2105,7 +2105,7 @@ bool pci_dev_run_wake(struct pci_dev *dev) 
{

	struct pci_bus *bus = dev->bus;



	if (device_run_wake(&dev->dev))

	if (device_can_wakeup(&dev->dev))

		return true;



	if (!dev->pme_support)
@@ -2118,7 +2118,7 @@ bool pci_dev_run_wake(struct pci_dev *dev) 
	while (bus->parent) {

		struct pci_dev *bridge = bus->self;



		if (device_run_wake(&bridge->dev))

		if (device_can_wakeup(&bridge->dev))

			return true;



		bus = bus->parent;
@@ -2126,7 +2126,7 @@ bool pci_dev_run_wake(struct pci_dev *dev) 


	/* We have reached the root bus. */

	if (bus->bridge)

		return device_run_wake(bus->bridge);

		return device_can_wakeup(bus->bridge);



	return false;

}

drivers/pci/pcie/pme.c

+1 −1
Original line number Diff line number Diff line
@@ -300,7 +300,7 @@ static irqreturn_t pcie_pme_irq(int irq, void *context) 
 */

static int pcie_pme_can_wakeup(struct pci_dev *dev, void *ign)

{

	device_set_run_wake(&dev->dev, true);

	device_set_wakeup_capable(&dev->dev, true);

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE