Commit de391d12 authored Nov 18, 2010 by Mattia Dongili Committed by Dmitry Torokhov Nov 18, 2010

Input: fix typo in keycode validation supporting large scancodes

Check the input_keymap_entry keycode size (u32) instead of the device's
(void*) when validating that keycode value can be stored in the keymap.

Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=22722



Signed-off-by: Mattia Dongili <malattia@linux.it>
Tested-by: Norbert Preining <preining@logic.at>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>

parent 6f07d31e

drivers/input/input.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -753,7 +753,7 @@ static int input_default_setkeycode(struct input_dev *dev,
		if (index >= dev->keycodemax)
		return -EINVAL;

		if (dev->keycodesize < sizeof(dev->keycode) &&
		if (dev->keycodesize < sizeof(ke->keycode) &&
		(ke->keycode >> (dev->keycodesize * 8)))
		return -EINVAL;

Admin message