Commit de329820 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

ext3: fix broken handling of EXT3_STATE_NEW 

In commit 9df93939 ("ext3: Use bitops to read/modify
EXT3_I(inode)->i_state") ext3 changed its internal 'i_state' variable to
use bitops for its state handling.  However, unline the same ext4
change, it didn't actually change the name of the field when it changed
the semantics of it.

As a result, an old use of 'i_state' remained in fs/ext3/ialloc.c that
initialized the field to EXT3_STATE_NEW.  And that does not work
_at_all_ when we're now working with individually named bits rather than
values that get masked.  So the code tried to mark the state to be new,
but in actual fact set the field to EXT3_STATE_JDATA.  Which makes no
sense at all, and screws up all the code that checks whether the inode
was newly allocated.

In particular, it made the xattr code unhappy, and caused various random
behavior, like apparently

	https://bugzilla.redhat.com/show_bug.cgi?id=577911



So fix the initialization, and rename the field to match ext4 so that we
don't have this happen again.

Cc: James Morris <jmorris@namei.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Daniel J Walsh <dwalsh@redhat.com>
Cc: Eric Paris <eparis@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent ad4ba059

fs/ext3/ialloc.c

+3 −1
Original line number Diff line number Diff line
@@ -582,7 +582,9 @@ got: 
	inode->i_generation = sbi->s_next_generation++;

	spin_unlock(&sbi->s_next_gen_lock);



	ei->i_state = EXT3_STATE_NEW;

	ei->i_state_flags = 0;

	ext3_set_inode_state(inode, EXT3_STATE_NEW);



	ei->i_extra_isize =

		(EXT3_INODE_SIZE(inode->i_sb) > EXT3_GOOD_OLD_INODE_SIZE) ?

		sizeof(struct ext3_inode) - EXT3_GOOD_OLD_INODE_SIZE : 0;

fs/ext3/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -2811,7 +2811,7 @@ struct inode *ext3_iget(struct super_block *sb, unsigned long ino) 
	inode->i_mtime.tv_sec = (signed)le32_to_cpu(raw_inode->i_mtime);

	inode->i_atime.tv_nsec = inode->i_ctime.tv_nsec = inode->i_mtime.tv_nsec = 0;



	ei->i_state = 0;

	ei->i_state_flags = 0;

	ei->i_dir_start_lookup = 0;

	ei->i_dtime = le32_to_cpu(raw_inode->i_dtime);

	/* We now have enough fields to check if the inode was active or not.

include/linux/ext3_fs.h

+3 −3
Original line number Diff line number Diff line
@@ -565,17 +565,17 @@ enum { 


static inline int ext3_test_inode_state(struct inode *inode, int bit)

{

	return test_bit(bit, &EXT3_I(inode)->i_state);

	return test_bit(bit, &EXT3_I(inode)->i_state_flags);

}



static inline void ext3_set_inode_state(struct inode *inode, int bit)

{

	set_bit(bit, &EXT3_I(inode)->i_state);

	set_bit(bit, &EXT3_I(inode)->i_state_flags);

}



static inline void ext3_clear_inode_state(struct inode *inode, int bit)

{

	clear_bit(bit, &EXT3_I(inode)->i_state);

	clear_bit(bit, &EXT3_I(inode)->i_state_flags);

}

#else

/* Assume that user mode programs are passing in an ext3fs superblock, not

include/linux/ext3_fs_i.h

+1 −1
Original line number Diff line number Diff line
@@ -87,7 +87,7 @@ struct ext3_inode_info { 
	 * near to their parent directory's inode.

	 */

	__u32	i_block_group;

	unsigned long	i_state;	/* Dynamic state flags for ext3 */

	unsigned long	i_state_flags;	/* Dynamic state flags for ext3 */



	/* block reservation info */

	struct ext3_block_alloc_info *i_block_alloc_info;

CRA Git | Maintained and supported by SUSTech CRA and CCSE