Btrfs: actually log directory we are fsync()'ing (de2b530b) · Commits · 戴 / test

If you just create a directory and then fsync that directory and then pull the power plug you will come back up and the directory will not be there. That is because we won't actually create directories if we've logged files inside of them since they will be created on replay, but in this check we will set our logged_trans of our current directory if it happens to be a directory, making us think it doesn't need to be logged. Fix the logic to only do this to parent directories. Thanks, Signed-off-by:

Josef Bacik <jbacik@fusionio.com> Signed-off-by:

Chris Mason <chris.mason@fusionio.com>

fs/btrfs/tree-log.c

+9 −1

Original line number	Diff line number	Diff line
		@@ -3805,6 +3805,7 @@ static noinline int check_parent_dirs_for_sync(struct btrfs_trans_handle *trans,
		int ret = 0;
		struct btrfs_root *root;
		struct dentry *old_parent = NULL;
		struct inode *orig_inode = inode;

		/*
		* for regular files, if its inode is already on disk, we don't
		@@ -3824,6 +3825,13 @@ static noinline int check_parent_dirs_for_sync(struct btrfs_trans_handle *trans,
		}

		while (1) {
		/*
		* If we are logging a directory then we start with our inode,
		* not our parents inode, so we need to skipp setting the
		* logged_trans so that further down in the log code we don't
		* think this inode has already been logged.
		*/
		if (inode != orig_inode)
		BTRFS_I(inode)->logged_trans = trans->transid;
		smp_mb();

Admin message