Commit de185ab4 authored Sep 05, 2014 by WANG Cong Committed by David S. Miller Sep 07, 2014

ipv6: restore the behavior of ipv6_sock_ac_drop()



It is possible that the interface is already gone after joining
the list of anycast on this interface as we don't hold a refcount
for the device, in this case we are safe to ignore the error.

What's more important, for API compatibility we should not
change this behavior for applications even if it were correct.

Fixes: commit a9ed4a29 ("ipv6: fix rtnl locking in setsockopt for anycast and multicast")
Cc: Sabrina Dubroca <sd@queasysnail.net>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent bc55dc63

net/ipv6/anycast.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -182,8 +182,6 @@ int ipv6_sock_ac_drop(struct sock sk, int ifindex, const struct in6_addr addr)
		rtnl_unlock();

		sock_kfree_s(sk, pac, sizeof(*pac));
		if (!dev)
		return -ENODEV;
		return 0;
		}

Admin message