Commit de08b5ac authored Jan 07, 2020 by Arnd Bergmann Committed by Miquel Raynal Jan 09, 2020

mtd: sm_ftl: fix NULL pointer warning



With gcc -O3, we get a new warning:

In file included from arch/arm64/include/asm/processor.h:28,
                 from drivers/mtd/sm_ftl.c:8:
In function 'memset',
    inlined from 'sm_read_sector.constprop' at drivers/mtd/sm_ftl.c:250:3:
include/linux/string.h:411:9: error: argument 1 null where non-null expected [-Werror=nonnull]
  return __builtin_memset(p, c, size);

>From all I can tell, this cannot happen (the function is called
either with a NULL buffer or with a -1 block number but not both),
but adding a check makes it more robust and avoids the warning.

Fixes: mmtom ("init/Kconfig: enable -O3 for all arches")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

parent 8bcef0d5

drivers/mtd/sm_ftl.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -247,6 +247,7 @@ static int sm_read_sector(struct sm_ftl *ftl,

		/* FTL can contain -1 entries that are by default filled with bits */
		if (block == -1) {
		if (buffer)
		memset(buffer, 0xFF, SM_SECTOR_SIZE);
		return 0;
		}

Admin message