Commit ddfbee9e authored Jul 26, 2019 by Thierry Reding Committed by David S. Miller Jul 27, 2019

net: stmmac: Do not request stmmaceth clock



The stmmaceth clock is specified by the slave_bus and apb_pclk clocks in
the device tree bindings for snps,dwc-qos-ethernet-4.10 compatible nodes
of this IP.

The subdrivers for these bindings will be requesting the stmmac clock
correctly at a later point, so there is no need to request it here and
cause an error message to be printed to the kernel log.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1a981c05

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

+8 −6

Original line number	Diff line number	Diff line
		@@ -521,6 +521,7 @@ stmmac_probe_config_dt(struct platform_device pdev, const char *mac)
		}

		/* clock setup */
		if (!of_device_is_compatible(np, "snps,dwc-qos-ethernet-4.10")) {
		plat->stmmac_clk = devm_clk_get(&pdev->dev,
		STMMAC_RESOURCE_NAME);
		if (IS_ERR(plat->stmmac_clk)) {
		@@ -528,6 +529,7 @@ stmmac_probe_config_dt(struct platform_device pdev, const char *mac)
		plat->stmmac_clk = NULL;
		}
		clk_prepare_enable(plat->stmmac_clk);
		}

		plat->pclk = devm_clk_get(&pdev->dev, "pclk");
		if (IS_ERR(plat->pclk)) {

Admin message