Commit dde5199c authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: aoa: Constify snd_kcontrol_new items 

Most of snd_kcontrol_new definitions are read-only and passed as-is.
Let's declare them as const for further optimization.

There should be no functional changes by this patch.

Link: https://lore.kernel.org/r/20200103081714.9560-33-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 454f5ec1

sound/aoa/codecs/onyx.c

+1 −1
Original line number Diff line number Diff line
@@ -413,7 +413,7 @@ static int onyx_snd_single_bit_put(struct snd_kcontrol *kcontrol, 
}



#define SINGLE_BIT(n, type, description, address, mask, flags)	 	\

static struct snd_kcontrol_new n##_control = {				\

static const struct snd_kcontrol_new n##_control = {			\

	.iface = SNDRV_CTL_ELEM_IFACE_##type,				\

	.name = description,						\

	.access = SNDRV_CTL_ELEM_ACCESS_READWRITE,			\

sound/aoa/codecs/tas.c

+1 −1
Original line number Diff line number Diff line
@@ -369,7 +369,7 @@ static int tas_snd_mixer_put(struct snd_kcontrol *kcontrol, 
}



#define MIXER_CONTROL(n,descr,idx)			\

static struct snd_kcontrol_new n##_control = {		\

static const struct snd_kcontrol_new n##_control = {	\

	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,		\

	.name = descr " Playback Volume",		\

	.access = SNDRV_CTL_ELEM_ACCESS_READWRITE,	\

sound/aoa/fabrics/layout.c

+1 −1
Original line number Diff line number Diff line
@@ -655,7 +655,7 @@ static int n##_control_put(struct snd_kcontrol *kcontrol, \ 
			!!ucontrol->value.integer.value[0]);		\

	return 1;							\

}									\

static struct snd_kcontrol_new n##_ctl = {				\

static const struct snd_kcontrol_new n##_ctl = {			\

	.iface = SNDRV_CTL_ELEM_IFACE_MIXER,				\

	.name = description,						\

	.access = SNDRV_CTL_ELEM_ACCESS_READWRITE,                      \

CRA Git | Maintained and supported by SUSTech CRA and CCSE