[SCSI] sg: remove unnecessary indentation (dddbf8d9) · Commits · 戴 / test

blocking is de-facto a constant and the now-removed comment wasn't all that useful either. Without them and the resulting indentation the code is a bit nicer to read. Signed-off-by:

Joern Engel <joern@logfs.org> Acked-by:

Douglas Gilbert <dgilbert@interlog.com> Signed-off-by:

James Bottomley <JBottomley@Parallels.com>

drivers/scsi/sg.c

+24 −29

Original line number	Diff line number	Diff line
		@@ -791,18 +791,14 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg)

		switch (cmd_in) {
		case SG_IO:
		{
		int blocking = 1; /* ignore O_NONBLOCK flag */

		if (sdp->detached)
		return -ENODEV;
		if (!scsi_block_when_processing_errors(sdp->device))
		return -ENXIO;
		if (!access_ok(VERIFY_WRITE, p, SZ_SG_IO_HDR))
		return -EFAULT;
		result =
		sg_new_write(sfp, filp, p, SZ_SG_IO_HDR,
		blocking, read_only, 1, &srp);
		result = sg_new_write(sfp, filp, p, SZ_SG_IO_HDR,
		1, read_only, 1, &srp);
		if (result < 0)
		return result;
		while (1) {
		@@ -824,7 +820,6 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg)
		}
		result = sg_new_read(sfp, p, SZ_SG_IO_HDR, srp);
		return (result < 0) ? result : 0;
		}
		case SG_SET_TIMEOUT:
		result = get_user(val, ip);
		if (result)

Admin message