Commit ddc790e9 authored by Randy Dunlap's avatar Randy Dunlap Committed by David S. Miller
Browse files

net: ethernet: broadcom: have drivers select DIMLIB as needed 

NET_VENDOR_BROADCOM is intended to control a kconfig menu only.
It should not have anything to do with code generation.
As such, it should not select DIMLIB for all drivers under
NET_VENDOR_BROADCOM.  Instead each driver that needs DIMLIB should
select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET).

Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1907021810220.13058@ramsan.of.borg/



Fixes: 4f75da36 ("linux/dim: Move implementation to .c files")
Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Cc: Tal Gilboa <talgi@mellanox.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>
Cc: netdev@vger.kernel.org
Cc: linux-rdma@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@mellanox.com>
Cc: Leon Romanovsky <leonro@mellanox.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Sagi Grimberg <sagi@grimberg.me>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f913eac8

drivers/net/ethernet/broadcom/Kconfig

+3 −1
Original line number Diff line number Diff line
@@ -8,7 +8,6 @@ config NET_VENDOR_BROADCOM 
	default y

	depends on (SSB_POSSIBLE && HAS_DMA) || PCI || BCM63XX || \

		   SIBYTE_SB1xxx_SOC

	select DIMLIB

	---help---

	  If you have a network (Ethernet) chipset belonging to this class,

	  say Y.
@@ -69,6 +68,7 @@ config BCMGENET 
	select FIXED_PHY

	select BCM7XXX_PHY

	select MDIO_BCM_UNIMAC

	select DIMLIB

	help

	  This driver supports the built-in Ethernet MACs found in the

	  Broadcom BCM7xxx Set Top Box family chipset.
@@ -188,6 +188,7 @@ config SYSTEMPORT 
	select MII

	select PHYLIB

	select FIXED_PHY

	select DIMLIB

	help

	  This driver supports the built-in Ethernet MACs found in the

	  Broadcom BCM7xxx Set Top Box family chipset using an internal
@@ -200,6 +201,7 @@ config BNXT 
	select LIBCRC32C

	select NET_DEVLINK

	select PAGE_POOL

	select DIMLIB

	---help---

	  This driver supports Broadcom NetXtreme-C/E 10/25/40/50 gigabit

	  Ethernet cards.  To compile this driver as a module, choose M here:

CRA Git | Maintained and supported by SUSTech CRA and CCSE