mmc: mediatek: fix CMD21/CMD19 timeout issue (ddc71387) · Commits · 戴 / test

we did not deal with the read data of CMD21/CMD19 if there is response CRC error of CMD21/CMD19, in this case, eMMC/SD may still in send-data state. therefore, all of next commands cannot get response as device is not in transfer state. for resolving this issue, still need deal with the data receive to make device back to transfer state. Signed-off-by:

Chaotian Jing <chaotian.jing@mediatek.com> Signed-off-by:

Ulf Hansson <ulf.hansson@linaro.org>

drivers/mmc/host/mtk-sd.c

+12 −2

Original line number	Diff line number	Diff line
		@@ -801,6 +801,12 @@ static bool msdc_cmd_done(struct msdc_host *host, int events,
		}

		if (!sbc_error && !(events & MSDC_INT_CMDRDY)) {
		if (cmd->opcode != MMC_SEND_TUNING_BLOCK &&
		cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200)
		/*
		* should not clear fifo/interrupt as the tune data
		* may have alreay come.
		*/
		msdc_reset_hw(host);
		if (events & MSDC_INT_RSPCRCERR) {
		cmd->error = -EILSEQ;
		@@ -885,7 +891,11 @@ static void msdc_start_command(struct msdc_host *host,
		static void msdc_cmd_next(struct msdc_host *host,
		struct mmc_request mrq, struct mmc_command cmd)
		{
		if (cmd->error \|\| (mrq->sbc && mrq->sbc->error))
		if ((cmd->error &&
		!(cmd->error == -EILSEQ &&
		(cmd->opcode == MMC_SEND_TUNING_BLOCK \|\|
		cmd->opcode == MMC_SEND_TUNING_BLOCK_HS200))) \|\|
		(mrq->sbc && mrq->sbc->error))
		msdc_request_done(host, mrq);
		else if (cmd == mrq->sbc)
		msdc_start_command(host, mrq, mrq->cmd);

Admin message