mm, cma: make parameters order consistent in func declaration and definition (dda02fd6) · Commits · 戴 / test

In the current code, the base and size parameters order is not consistent in functions declaration and definition. If someone calls these functions according to the declaration parameters order in cma.h, he will run into some bug and it's hard to find the reason. This patch makes the parameters order consistent in functions declaration and definition. Signed-off-by:

Weijie Yang <weijie.yang@samsung.com> Acked-by:

Michal Nazarewicz <mina86@mina86.com> Signed-off-by:

Marek Szyprowski <m.szyprowski@samsung.com>

include/linux/cma.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -18,12 +18,12 @@ struct cma;
		extern phys_addr_t cma_get_base(struct cma *cma);
		extern unsigned long cma_get_size(struct cma *cma);

		extern int __init cma_declare_contiguous(phys_addr_t size,
		phys_addr_t base, phys_addr_t limit,
		extern int __init cma_declare_contiguous(phys_addr_t base,
		phys_addr_t size, phys_addr_t limit,
		phys_addr_t alignment, unsigned int order_per_bit,
		bool fixed, struct cma **res_cma);
		extern int cma_init_reserved_mem(phys_addr_t size,
		phys_addr_t base, int order_per_bit,
		extern int cma_init_reserved_mem(phys_addr_t base,
		phys_addr_t size, int order_per_bit,
		struct cma **res_cma);
		extern struct page cma_alloc(struct cma cma, int count, unsigned int align);
		extern bool cma_release(struct cma cma, struct page pages, int count);

Admin message