Commit dd981ab0 authored by Antonio Quartulli's avatar Antonio Quartulli Committed by Antonio Quartulli
Browse files

batman-adv: use the proper header len when checking the TTVN 



Unicast packet might be of type either UNICAST or
UNICAST4ADDR.
In the two cases the header size is different, but the
mechanism checking the TTVN field was assuming it to be
always of the same type (UNICAST), so failing to access the
inner Ethernet header in case of UNICAST4ADDR.

Fix this by passing the real header length as argument.

Signed-off-by: default avatarAntonio Quartulli <antonio@open-mesh.com>
Signed-off-by: default avatarMarek Lindner <lindner_marek@yahoo.de>
parent 60d509fa

net/batman-adv/routing.c

+5 −6
Original line number Diff line number Diff line
@@ -924,7 +924,7 @@ out: 
}



static int batadv_check_unicast_ttvn(struct batadv_priv *bat_priv,

				     struct sk_buff *skb) {

				     struct sk_buff *skb, int hdr_len) {

	uint8_t curr_ttvn, old_ttvn;

	struct batadv_orig_node *orig_node;

	struct ethhdr *ethhdr;
@@ -933,7 +933,7 @@ static int batadv_check_unicast_ttvn(struct batadv_priv *bat_priv, 
	int is_old_ttvn;



	/* check if there is enough data before accessing it */

	if (pskb_may_pull(skb, sizeof(*unicast_packet) + ETH_HLEN) < 0)

	if (pskb_may_pull(skb, hdr_len + ETH_HLEN) < 0)

		return 0;



	/* create a copy of the skb (in case of for re-routing) to modify it. */
@@ -941,7 +941,7 @@ static int batadv_check_unicast_ttvn(struct batadv_priv *bat_priv, 
		return 0;



	unicast_packet = (struct batadv_unicast_packet *)skb->data;

	ethhdr = (struct ethhdr *)(skb->data + sizeof(*unicast_packet));

	ethhdr = (struct ethhdr *)(skb->data + hdr_len);



	/* check if the destination client was served by this node and it is now

	 * roaming. In this case, it means that the node has got a ROAM_ADV
@@ -1048,8 +1048,7 @@ int batadv_recv_unicast_packet(struct sk_buff *skb, 


	if (batadv_check_unicast_packet(bat_priv, skb, hdr_size) < 0)

		return NET_RX_DROP;



	if (!batadv_check_unicast_ttvn(bat_priv, skb))

	if (!batadv_check_unicast_ttvn(bat_priv, skb, hdr_size))

		return NET_RX_DROP;



	/* packet for me */
@@ -1093,7 +1092,7 @@ int batadv_recv_ucast_frag_packet(struct sk_buff *skb, 
	if (batadv_check_unicast_packet(bat_priv, skb, hdr_size) < 0)

		return NET_RX_DROP;



	if (!batadv_check_unicast_ttvn(bat_priv, skb))

	if (!batadv_check_unicast_ttvn(bat_priv, skb, hdr_size))

		return NET_RX_DROP;



	unicast_packet = (struct batadv_unicast_frag_packet *)skb->data;

CRA Git | Maintained and supported by SUSTech CRA and CCSE