Commit dd89d82e authored May 15, 2019 by Dan Carpenter Committed by Eduardo Valentin Sep 22, 2019

thermal: thermal_mmio: remove some dead code

The platform_get_resource() function doesn't return error pointers, it
returns NULL. The way this is normally done, is that we pass the NULL
resource to devm_ioremap_resource() and then check for errors from that.
See the comment in front of devm_ioremap_resource() for more details.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Talel Shenhar <talel@amazon.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>

parent 56037cad

drivers/thermal/thermal_mmio.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -53,13 +53,6 @@ static int thermal_mmio_probe(struct platform_device *pdev)
		return -ENOMEM;

		resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (IS_ERR(resource)) {
		dev_err(&pdev->dev,
		"fail to get platform memory resource (%ld)\n",
		PTR_ERR(resource));
		return PTR_ERR(resource);
		}

		sensor->mmio_base = devm_ioremap_resource(&pdev->dev, resource);
		if (IS_ERR(sensor->mmio_base)) {
		dev_err(&pdev->dev, "failed to ioremap memory (%ld)\n",

Admin message