Commit dd7db149 authored Aug 17, 2020 by Zhihao Cheng Committed by Richard Weinberger Sep 17, 2020

ubifs: ubifs_jnl_change_xattr: Remove assertion 'nlink > 0' for host inode



Changing xattr of a temp file will trigger following assertion failed
and make ubifs turn into readonly filesystem:
  ubifs_assert_failed [ubifs]: UBIFS assert failed: host->i_nlink > 0,
  in fs/ubifs/journal.c:1801

Reproducer:
  1. fd = open(__O_TMPFILE)
  2. fsetxattr(fd, key, value2, XATTR_CREATE)
  3. fsetxattr(fd, key, value2, XATTR_REPLACE)

Fix this by removing assertion 'nlink > 0' for host inode.

Reported-by: Chengsong Ke <kechengsong@huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent d005f8c6

fs/ubifs/journal.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1800,7 +1800,6 @@ int ubifs_jnl_change_xattr(struct ubifs_info c, const struct inode inode,
		u8 hash[UBIFS_HASH_ARR_SZ];

		dbg_jnl("ino %lu, ino %lu", host->i_ino, inode->i_ino);
		ubifs_assert(c, host->i_nlink > 0);
		ubifs_assert(c, inode->i_nlink > 0);
		ubifs_assert(c, mutex_is_locked(&host_ui->ui_mutex));

Admin message