ohci-s3c2410: use HUB_CHAR_* (dd709764) · Commits · 戴 / test

Fix using the bare numbers to set the 'wHubCharacteristics' field of the Hub Descriptor while the values are #define'd in <linux/usb/ch11.h>. While at it, stop setting already set HUB_CHAR_INDV_PORT_LPSM once again. Signed-off-by:

Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/usb/host/ohci-s3c2410.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -249,14 +249,14 @@ static int ohci_s3c2410_hub_control(
		*/

		desc->wHubCharacteristics &= ~cpu_to_le16(HUB_CHAR_LPSM);
		desc->wHubCharacteristics \|= cpu_to_le16(0x0001);
		desc->wHubCharacteristics \|= cpu_to_le16(
		HUB_CHAR_INDV_PORT_LPSM);

		if (info->enable_oc) {
		desc->wHubCharacteristics &= ~cpu_to_le16(
		HUB_CHAR_OCPM);
		desc->wHubCharacteristics \|= cpu_to_le16(
		0x0008 \|
		0x0001);
		HUB_CHAR_INDV_PORT_OCPM);
		}

		dev_dbg(hcd->self.controller, "wHubCharacteristics after 0x%04x\n",

Admin message