Commit dd5f6279 authored Nov 01, 2017 by zhangyi (F) Committed by Jan Kara Nov 01, 2017

quota: fix potential infinite loop



In dquot_writeback_dquots(), we write back dquot from dirty dquots
list. There is a potential infinite loop if ->write_dquot() failure
and forget remove dquot from the list. This patch clear dirty bit
anyway to avoid it.

Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: Jan Kara <jack@suse.cz>

parent cb917757

fs/quota/dquot.c

+9 −2

Original line number	Diff line number	Diff line
		@@ -644,8 +644,15 @@ int dquot_writeback_dquots(struct super_block *sb, int type)
		spin_unlock(&dq_list_lock);
		dqstats_inc(DQST_LOOKUPS);
		err = sb->dq_op->write_dquot(dquot);
		if (!ret && err)
		if (err) {
		/*
		* Clear dirty bit anyway to avoid infinite
		* loop here.
		*/
		clear_dquot_dirty(dquot);
		if (!ret)
		ret = err;
		}
		dqput(dquot);
		spin_lock(&dq_list_lock);
		}

Admin message