pata_efar: fix wrong MWDMA timings being programmed (dd221f9c) · Commits · 戴 / test

Do not clear MWDMA timings for device on the other port when programming slave device. This change should be safe as this is how we have been doing things in IDE slc90e66 host driver for years. Signed-off-by:

Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by:

Jeff Garzik <jgarzik@redhat.com>

drivers/ata/pata_efar.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -201,7 +201,7 @@ static void efar_set_dmamode (struct ata_port ap, struct ata_device adev)
		master_data &= 0xFF4F; /* Mask out IORDY\|TIME1\|DMAONLY */
		master_data \|= control << 4;
		pci_read_config_byte(dev, 0x44, &slave_data);
		slave_data &= (0x0F + 0xE1 * ap->port_no);
		slave_data &= ap->port_no ? 0x0F : 0xF0;
		/* Load the matching timing */
		slave_data \|= ((timings[pio][0] << 2) \| timings[pio][1]) << (ap->port_no ? 4 : 0);
		pci_write_config_byte(dev, 0x44, slave_data);

Admin message