x86/intel_mid: Fix the Kconfig for MID selection (dd137525) · Commits · 戴 / test

We currently fail to build on CONFIG_X86_INTEL_MID=y and CONFIG_X86_MRST unset. We could build all the bits to make generic MID work if you picked MID platform alone but that's really silly. Instead use select and two variables. This looks a bit daft right now but once we add a Medfield selection it'll start to look a good deal more sensible. Reported-by:

Ingo Molnar <mingo@elte.hu> Reported-by:

Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by:

Alan Cox <alan@linux.intel.com> Link: http://lkml.kernel.org/r/20111205231433.28811.51297.stgit@bob.linux.org.uk Signed-off-by:

Ingo Molnar <mingo@elte.hu>

arch/x86/Kconfig

+3 −2

Original line number	Diff line number	Diff line
		@@ -390,7 +390,7 @@ config X86_INTEL_CE
		This option compiles in support for the CE4100 SOC for settop
		boxes and media devices.

		config X86_INTEL_MID
		config X86_WANT_INTEL_MID
		bool "Intel MID platform support"
		depends on X86_32
		depends on X86_EXTENDED_PLATFORM
		@@ -399,7 +399,7 @@ config X86_INTEL_MID
		systems which do not have the PCI legacy interfaces (Moorestown,
		Medfield). If you are building for a PC class system say N here.

		if X86_INTEL_MID
		if X86_WANT_INTEL_MID

		config X86_MRST
		bool "Moorestown MID platform"
		@@ -411,6 +411,7 @@ config X86_MRST
		select SPI
		select INTEL_SCU_IPC
		select X86_PLATFORM_DEVICES
		select X86_INTEL_MID
		---help---
		Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin
		Internet Device(MID) platform. Moorestown consists of two chips:

Admin message