ibmvnic: Warn unknown speed message only when carrier is present (dd0f9d89) · Commits · 戴 / test

With commit ("net/ibmvnic: Update carrier state after link state change") we are now able to detect when the carrier is properly present in the device, so only report an unexpected unknown speed when it is properly detected. Unknown speed is expected to be seen by the device in case the backing device has no link detected. Reported-by:

Abdul Haleem <abdhalee@linux.vnet.ibm.com> Tested-by:

Abdul Haleem <abdhalee@linux.vnet.ibm.com> Signed-off-by:

Murilo Fossa Vicentini <muvic@linux.ibm.com> Reviewed-by:

Thomas Falcon <tlfalcon@linux.ibm.com>

drivers/net/ethernet/ibm/ibmvnic.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -4312,13 +4312,14 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq,
		{
		struct net_device *netdev = adapter->netdev;
		int rc;
		__be32 rspeed = cpu_to_be32(crq->query_phys_parms_rsp.speed);

		rc = crq->query_phys_parms_rsp.rc.code;
		if (rc) {
		netdev_err(netdev, "Error %d in QUERY_PHYS_PARMS\n", rc);
		return rc;
		}
		switch (cpu_to_be32(crq->query_phys_parms_rsp.speed)) {
		switch (rspeed) {
		case IBMVNIC_10MBPS:
		adapter->speed = SPEED_10;
		break;
		@@ -4344,8 +4345,8 @@ static int handle_query_phys_parms_rsp(union ibmvnic_crq *crq,
		adapter->speed = SPEED_100000;
		break;
		default:
		netdev_warn(netdev, "Unknown speed 0x%08x\n",
		cpu_to_be32(crq->query_phys_parms_rsp.speed));
		if (netif_carrier_ok(netdev))
		netdev_warn(netdev, "Unknown speed 0x%08x\n", rspeed);
		adapter->speed = SPEED_UNKNOWN;
		}
		if (crq->query_phys_parms_rsp.flags1 & IBMVNIC_FULL_DUPLEX)

Admin message