Commit dcf550e5 authored Apr 29, 2020 by Josh Poimboeuf Committed by Jiri Kosina May 08, 2020

livepatch: Disallow vmlinux.ko



This is purely a theoretical issue, but if there were a module named
vmlinux.ko, the livepatch relocation code wouldn't be able to
distinguish between vmlinux-specific and vmlinux.o-specific KLP
relocations.

If CONFIG_LIVEPATCH is enabled, don't allow a module named vmlinux.ko.

Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent a811c1fa

kernel/livepatch/core.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1139,6 +1139,11 @@ int klp_module_coming(struct module *mod)
		if (WARN_ON(mod->state != MODULE_STATE_COMING))
		return -EINVAL;

		if (!strcmp(mod->name, "vmlinux")) {
		pr_err("vmlinux.ko: invalid module name");
		return -EINVAL;
		}

		mutex_lock(&klp_mutex);
		/*
		* Each module has to know that klp_module_coming()

Admin message