ice: Use EOPNOTSUPP instead of ENOTSUPP (dced8ad3) · Commits · 戴 / test

Using ENOTSUPP almost always results in some bizarre error message to be printed in userspace. This is likely because ENOTSUPP was defined for the NFS protocol (as per a comment in include/linux/errno.h). Use EOPNOTSUPP instead. Signed-off-by:

Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> Signed-off-by:

Tony Nguyen <anthony.l.nguyen@intel.com> Tested-by:

Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:

Jeff Kirsher <jeffrey.t.kirsher@intel.com>

drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1429,7 +1429,7 @@ static int ice_pci_sriov_ena(struct ice_pf *pf, int num_vfs)
		if (num_vfs > pf->num_vfs_supported) {
		dev_err(dev, "Can't enable %d VFs, max VFs supported is %d\n",
		num_vfs, pf->num_vfs_supported);
		return -ENOTSUPP;
		return -EOPNOTSUPP;
		}

		dev_info(dev, "Allocating %d VFs\n", num_vfs);

drivers/net/ethernet/intel/ice/ice_xsk.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -24,7 +24,7 @@ ice_xsk_umem_setup(struct ice_vsi __always_unused *vsi,
		struct xdp_umem __always_unused *umem,
		u16 __always_unused qid)
		{
		return -ENOTSUPP;
		return -EOPNOTSUPP;
		}

		static inline void
		@@ -63,7 +63,7 @@ static inline int
		ice_xsk_wakeup(struct net_device __always_unused *netdev,
		u32 __always_unused queue_id, u32 __always_unused flags)
		{
		return -ENOTSUPP;
		return -EOPNOTSUPP;
		}

		#define ice_xsk_clean_rx_ring(rx_ring) do {} while (0)

Admin message