Commit dcb2ff56 authored Oct 10, 2016 by Heinz Mauelshagen Committed by Mike Snitzer Oct 14, 2016

dm mirror: fix read error on recovery after default leg failure



If a default leg has failed, any read will cause a new operational
default leg to be selected and the read is resubmitted.  But until now
the read will return failure even though it was successful due to
resubmission.  The reason for this is bio->bi_error was not being
cleared before resubmitting the bio.

Fix by clearing bio->bi_error before resubmission.

Fixes: 4246a0b6 ("block: add a bi_error field to struct bio")
Cc: stable@vger.kernel.org # 4.3+
Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent 5c33677c

drivers/md/dm-raid1.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1292,6 +1292,7 @@ static int mirror_end_io(struct dm_target ti, struct bio bio, int error)

		dm_bio_restore(bd, bio);
		bio_record->details.bi_bdev = NULL;
		bio->bi_error = 0;

		queue_bio(ms, bio, rw);
		return DM_ENDIO_INCOMPLETE;

Admin message