Commit dcaf1123 authored Feb 13, 2015 by Paolo Bonzini Committed by Linus Torvalds Feb 13, 2015

checkpatch: fix UNNECESSARY_KERN_LEVEL false positive



KERN_<LEVEL> is never redundant with printk_ratelimited or printk_once.
(Except perhaps in the sense that you could use e.g.  pr_err_ratelimited
or pr_err_once, but that would apply to printk as well).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: Andy Whitcroft <apw@canonical.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e23ef1f3

scripts/checkpatch.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -4547,7 +4547,7 @@ sub process {
		}

		# check for logging functions with KERN_<LEVEL>
		if ($line !~ /printk\s*\(/ &&
		if ($line !~ /printk(?:_ratelimited\|_once)?\s*\(/ &&
		$line =~ /\b$logFunctions\s\(.\b(KERN_[A-Z]+)\b/) {
		my $level = $1;
		if (WARN("UNNECESSARY_KERN_LEVEL",

Admin message